[2.1] Pin external package versions #15369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Apr 15, 2019
dougbu
reviewed
Apr 15, 2019
| @@ -49,6 +27,30 @@ | |||
| <MicrosoftExtensionsConfigurationJsonPackageVersion>2.1.1</MicrosoftExtensionsConfigurationJsonPackageVersion> | |||
| <MicrosoftExtensionsConfigurationPackageVersion>2.1.1</MicrosoftExtensionsConfigurationPackageVersion> | |||
| <MicrosoftExtensionsDependencyInjectionPackageVersion>2.1.1</MicrosoftExtensionsDependencyInjectionPackageVersion> | |||
| <MicrosoftExtensionsDependencyModelPackageVersion>2.1.0</MicrosoftExtensionsDependencyModelPackageVersion> | |||
There was a problem hiding this comment.
This may cause problems because Microsoft.Extensions.Dependency model comes from dotnet/core-setup i.e. it's not really an external package. Ane, we've had problems in the past with keeping this file up-to-date when a patch release includes (or doesn't include) a package.
There was a problem hiding this comment.
Copied from the 2.2 branch. Should we change there too?
There was a problem hiding this comment.
I think this repo is only using M.Ext.DependencyModel for tests, right? In which case, I doubt this matters.
There was a problem hiding this comment.
If we don't have to make further changes, great. IOW, let's see how things build tonight.
/cc @aspnet/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.